fallintoplace opened a new pull request, #1377:
URL: https://github.com/apache/iceberg-go/pull/1377

   ## Summary
   
   `ParseGCSConfig` used to enable JSON reads on `gcs.usejsonapi` whenever the 
key existed, so values like `"false"` still switched it on.
   
   This change now parses the property as a boolean using `strconv.ParseBool` 
and only enables JSON reads when it resolves to `true`.
   
   Also included:
   - Unit tests covering `true`, `false`, absent, and invalid values 
(`not-a-bool`).
   - Documentation update in `website/src/configuration.md`.
   - Removed outdated comment in `io/config.go` that implied truthy-by-presence 
behavior.
   
   ## Validation
   
   - `go test ./io/gocloud -run TestParseGCSConfigUseJSONAPI -count=1`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to