fallintoplace opened a new pull request, #1375: URL: https://github.com/apache/iceberg-go/pull/1375
## Summary - Change writer factory options to return errors so `withFactoryFileSchema` can propagate Arrow schema conversion failures instead of panicking. - Update `withFactoryFileSchema` to return a construction error when `SchemaToArrowSchema` fails. - Update `newWriterFactory` to stop option iteration and return the first option error. - Add regression test: `TestNewWriterFactoryReturnsErrorForInvalidFileSchema` verifies invalid/unsupported file schemas fail with error and no panic. ## Verification - `go test ./table -run TestRollingDataWriter/TestNewWriterFactoryReturnsErrorForInvalidFileSchema -count=1` - `go test ./table -run TestRollingDataWriter -count=1` - `go test ./table -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
