fallintoplace commented on PR #1365:
URL: https://github.com/apache/iceberg-go/pull/1365#issuecomment-4881641848
Implemented the remaining validation gap in this PR.
What I added on top of bbc3571:
- BucketTransform.MarshalText now validates NumBuckets and returns
ErrInvalidArgument for <=0.
- Added transform validation in partition construction
(addSpecFieldInternal) so NewPartitionSpecOpts paths reject invalid bucket
transforms with the same invalid-argument root cause.
- Added regression tests:
- TestBucketTransform_MarshalTextRejectsInvalidBuckets
- TestPartitionSpecRejectsInvalidBucketTransform
- TestPartitionSpec_MarshalTextRejectsInvalidBucketTransform
Validation run:
- go test ./... -count=1 ✅
New head commit: 35baa49 on fix/buckettransform-num-buckets-validate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
