fallintoplace commented on PR #1368: URL: https://github.com/apache/iceberg-go/pull/1368#issuecomment-4881612232
Implemented this in commit f006261 and pushed to my branch: - decoupled fanout coordination and writer drain contexts in both data and position-delete fanout paths (writerCtx / fanoutCtx) - switched close/finish path to use `closeAll()` on successful fanout completion and `abortAll()` on fanout errors - added post-drain writer cancellation so the successful graceful path doesn’t leak context - added a regression test in `partitioned_fanout_writer_test.go` that drives fanout success completion and verifies all rows are still flushed I also updated positional-delete fanout test call sites for the changed `processBatch` signature. `go test ./table -count=1` passes locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
