thswlsqls opened a new pull request, #17087: URL: https://github.com/apache/iceberg/pull/17087
Closes #17074 ## Summary - `HiveViewOperations.doCommit()` threw `CommitFailedException` immediately on the HMS "modified" message, without checking whether the alter actually succeeded. - Mirrors `HiveTableOperations.doCommit()`, which already double-checks via `checkCommitStatusStrict()` before deciding the commit truly failed. - Related: merged fix in HiveTableOperations.doCommit() (PR #12637); sibling code at hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java. ## Testing done - Added `TestHiveViewCommits#modifiedConcurrentlyExceptionSucceedsWhenActuallyCommitted`, which spies `persistTable` to actually persist then throw a "modified" exception, and asserts the commit completes and `refresh()` reflects the new metadata location. - `./gradlew :iceberg-hive-metastore:check` — 13/13 tests passed in `TestHiveViewCommits`, 20/20 in `TestHiveCommitLocks`, 16/16 in `TestHiveCommits`; full module check build succeeded. - Not a revapi-scoped module (hive-metastore is not in the api/core/parquet/orc/common/data set), so revapi was skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
