zeroshade commented on code in PR #1357:
URL: https://github.com/apache/iceberg-go/pull/1357#discussion_r3521550050
##########
table/updates.go:
##########
@@ -79,6 +79,10 @@ func (u *Updates) UnmarshalJSON(data []byte) error {
return err
}
+ var updates Updates
Review Comment:
Optional nit: when the incoming array is empty this assigns a nil slice, so
an incoming `[]` round-trips to `null` on re-marshal (same pattern in
table/requirements.go and the view/updates.go + view/requirements.go
equivalents). If you want `[]` to stay `[]`, allocate the temp with
make(Updates, 0, len(rawUpdates)) even when len==0. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
