zeroshade commented on code in PR #1352:
URL: https://github.com/apache/iceberg-go/pull/1352#discussion_r3521378563
##########
catalog/hive/schema.go:
##########
@@ -97,14 +97,14 @@ const (
// are set to viewSQL.
func constructHiveViewTable(dbName, viewName, location, metadataLocation
string, schema *iceberg.Schema, viewSQL string, props map[string]string)
*hive_metastore.Table {
parameters := make(map[string]string)
- parameters[TableTypeKey] = TableTypeIcebergView
- parameters[MetadataLocationKey] = metadataLocation
- parameters[ExternalKey] = "TRUE"
for k, v := range props {
if v != "" {
parameters[k] = v
}
}
+ parameters[TableTypeKey] = TableTypeIcebergView
+ parameters[MetadataLocationKey] = metadataLocation
+ parameters[ExternalKey] = "TRUE"
Review Comment:
Consistency (optional): the table path below deletes
`PreviousMetadataLocationKey` from user props before setting reserved keys, but
this view path does not. If a user passes `previous_metadata_location` for a
view it will be persisted as-is — intentional? If not, mirror the table path
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
