viirya commented on PR #2558: URL: https://github.com/apache/iceberg-rust/pull/2558#issuecomment-4878182511
That makes sense — I was focused on the CI/build-time cost, but you're right that's not really the concern. The real cost is whoever touches reader internals during the refactor having to understand and fix a benchmark they didn't write, and that shouldn't be pushed onto them. Let's keep this PR open rather than merge it. I'll treat it as ours to maintain — watching for reader-internal changes and updating the benchmark to match — and revisit merging once the file format API work settles. Thanks for pushing on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
