thswlsqls opened a new pull request, #17064: URL: https://github.com/apache/iceberg/pull/17064
Closes #17062 ## Summary - `ADLSInputStream.read()`/`read(byte[], int, int)` propagated the raw `IOException` from `stream.read(...)` when the file was deleted after the stream opened, instead of translating it to `NotFoundException`. - `openRange()` in the same class already does this translation; this change makes `read()`/`read(byte[], int, int)` consistent with it, and with `GCSInputStream`'s `GCSExceptionUtil.throwNotFoundIfNotPresent` pattern. - Follow-up to issue #13528 (fixed by PR #15806/#15734), which covered `openRange`/`readFully`/`readTail` but missed the mid-stream `read` methods. - azure is outside the REVAPI-checked module set and `ADLSInputStream` is package-private, so no API compatibility impact. ## Testing done - Added `TestADLSInputStream#readTranslatesNotFoundOnMidStreamRead` and `#readBufferTranslatesNotFoundOnMidStreamRead`, covering `read()` and `read(byte[], int, int)` throwing `NotFoundException` when the mocked stream raises an `IOException` wrapping a `BlobStorageException` with `x-ms-error-code: BlobNotFound`. - `./gradlew :iceberg-azure:test --tests "org.apache.iceberg.azure.adlsv2.TestADLSInputStream"` — 6 tests passed. - `./gradlew :iceberg-azure:spotlessCheck :iceberg-azure:checkstyleMain :iceberg-azure:checkstyleTest` — passed. (`:iceberg-azure:check` also runs `integrationTest`, which requires Docker/Azurite and was not available in this environment, so unit test/style/checkstyle were verified separately as shown above.) - revapi: not applicable (azure module is outside REVAPI scope). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
