gaborkaszab commented on code in PR #17041:
URL: https://github.com/apache/iceberg/pull/17041#discussion_r3518120646
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -104,6 +105,31 @@ private TrackingStruct(TrackingStruct toCopy) {
this.replacedPositions = replacedPositions;
}
+ @VisibleForTesting
+ TrackingStruct(
Review Comment:
There is one significant difference between the 2: On the linked PR it's
`TrackedFileStruct` that we test, no need to verify fields of `TrackingStruct`,
hence overrides of manifestLocation, manifestPos functions won't loose
coverage. While here it's `TrackingStruct` itself under test, we can't have an
override of such functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
