rdblue commented on code in PR #16686:
URL: https://github.com/apache/iceberg/pull/16686#discussion_r3508300589
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -256,16 +264,15 @@ SnapshotSummary.Builder
buildSummary(Iterable<ManifestFile> manifests) {
for (ManifestFile manifest : manifests) {
PartitionSpec manifestSpec = specsById.get(manifest.partitionSpecId());
- Iterable<F> manifestDeletes =
filteredManifestToDeletedFiles.get(manifest);
- if (manifestDeletes != null) {
- for (F file : manifestDeletes) {
+ FilterResult<F> result = filteredManifestResults.get(manifest);
+ if (result != null) {
+ for (F file : result.deletedFiles()) {
summaryBuilder.deletedFile(manifestSpec, file);
}
+
summaryBuilder.incrementDuplicateDeletes(result.duplicateDeleteCount());
Review Comment:
This goes a lot farther than I think is necessary to make the duplicate
delete count more reliable. The main problem is knowing that duplicate deletes
have occurred, then you should go and find out which file was duplicated and
how the duplication happened. The need is to produce anything non-zero. Still
this isn't wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
