badalprasadsingh commented on PR #1244: URL: https://github.com/apache/iceberg-go/pull/1244#issuecomment-4850836762
Hey @laskoviymishka, 1. It now adopts the _Java contract_: the `ALTER` now runs only when `jdbc.schema-version=V1` is set, otherwise we _warn_ and stay on `V0` behind the NULL-tolerant read path. 2. For actual testing of the `MSSQL`/`Oracle` `ALTER`/`probe`, we would be needing those engines in the CI. For now, can we keep it out of scope, and open a new PR for it? 3. Other than that, all the smaller comments addressed: `ADD COLUMN` is replaced with dialect-specific `DDL`, the `PG/MSSQL` probes are scoped to the current schema, and probe errors now fail fast at open. Please do have a look whenever you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
