rdblue commented on code in PR #16867:
URL: https://github.com/apache/iceberg/pull/16867#discussion_r3502364397
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -53,6 +56,15 @@ static DeleteFile asEqualityDeleteFile(TrackedFile file,
Map<Integer, PartitionS
return new TrackedEqualityDeleteFile(file, resolveSpec(file, specsById));
}
+ static ManifestFile asManifestFile(TrackedFile file) {
+ Preconditions.checkArgument(
+ file.contentType() == FileContent.DATA_MANIFEST
+ || file.contentType() == FileContent.DELETE_MANIFEST,
+ "Invalid content type for ManifestFile: %s",
+ file.contentType());
+ return new TrackedManifestFile(file);
+ }
+
/** Shared base for all tracked file adapters. */
Review Comment:
This is no longer true. How about "Shared base for data and delete file
adapters"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
