rambleraptor commented on code in PR #1283:
URL: https://github.com/apache/iceberg-go/pull/1283#discussion_r3502181939
##########
table/table.go:
##########
@@ -530,6 +530,15 @@ func (t Table) doCommit(ctx context.Context, updates
[]Update, reqs []Requiremen
return nil, err
}
+ // The commit succeeded. Inner data manifests written by superseded
retry
+ // attempts (a rewrite re-merges everything on each retry) are now
orphaned
+ // objects; the committed snapshot references only the final attempt's.
+ for _, u := range updates {
+ if su, ok := u.(*addSnapshotUpdate); ok &&
su.supersededManifests != nil {
+ orphanedManifests = append(orphanedManifests,
*su.supersededManifests...)
Review Comment:
Yeah, I ended up leaving this as a follow-up if that's alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
