danielcweeks commented on code in PR #16611:
URL: https://github.com/apache/iceberg/pull/16611#discussion_r3501996141
##########
core/src/test/java/org/apache/iceberg/formats/TestFormatModelRegistry.java:
##########
@@ -86,6 +88,77 @@ void testFailingReRegistrations() {
.hasMessageContaining("Cannot register class");
}
+ @Test
+ void registerDoesNotFailWhenClassThrowsNoClassDefFoundOnInvoke() {
Review Comment:
With the latest updates, the tests do seem detached from what's going on in
`InternalData` or `FormatModelRegistry`. It's particularly difficult to test
this because it's being triggered from a static block.
The only way I can think to test this is to create an `IsolatingClassLoader`
that just loads that (or a subset) of classes to trigger this behavior in a way
that we can test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
