tanmayrauth commented on PR #1343: URL: https://github.com/apache/iceberg-go/pull/1343#issuecomment-4846857670
Thanks for the thorough pass @laskoviymishka . Addressed all four blockers: Combine always wraps now (typed-nil hole closed), panics re-surface at warn with the reporter %T, dropped the sealed marker + renamed to MetricsReport, and both tests assert what they're named for (log output + read-under-write under -race, with test-race now covering ./metrics/...). Also took the easy nits — var _ Reporter assertion and lazy slog.Default resolution. Left Reset()-barrier and the initialize/Close lifecycle for the #1236 follow-up. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
