RussellSpitzer commented on code in PR #16999:
URL: https://github.com/apache/iceberg/pull/16999#discussion_r3493831248
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -225,7 +226,12 @@ public DeleteOrphanFilesSparkAction
usePrefixListing(boolean newUsePrefixListing
private Dataset<String> filteredCompareToFileList() {
Dataset<Row> files = compareToFileList;
if (location != null) {
- files = files.filter(files.col(FILE_PATH).startsWith(location));
+ String strippedLocation = LocationUtil.stripTrailingSlash(location);
Review Comment:
Why don't we just always add the seperator here? What does the check below
get us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
