the-onewho-knocks commented on code in PR #1321:
URL: https://github.com/apache/iceberg-go/pull/1321#discussion_r3491547094
##########
manifest.go:
##########
@@ -1274,6 +1274,16 @@ func WithManifestFileContent(content ManifestContent)
ManifestFileOption {
}
}
+// WithManifestFileFirstRowID sets the first_row_id on a v3+ data manifest.
+// Silently no-ops on v1/v2 manifests since the field does not exist in those
formats.
+func WithManifestFileFirstRowID(firstRowID int64) ManifestFileOption {
Review Comment:
Since WriteManifestV3 takes firstRowID directly as a parameter rather than
going through a reusable ManifestFileOption closure, this particular aliasing
pattern goes away but I'll still make sure the value is copied into its own
allocation at the point it's stored on the manifestFile, same as AddManifests
does, rather than taking the address of a shared variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
