wgtmac commented on PR #759: URL: https://github.com/apache/iceberg-cpp/pull/759#issuecomment-4829979844
Ah, I didn't notice this PR before my agent raised https://github.com/apache/iceberg-cpp/pull/786. By practice we should respect the 1st PR that works on the same issue. However I think this PR chose the wrong direction (changed the semantics of Schema::Select) and applied a more complex fix (relied on heavy call to Schema::Select for validation). Do you mind changing your PR to use the approach in https://github.com/apache/iceberg-cpp/pull/786? Then I can merge this one and close that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
