huan233usc commented on code in PR #746:
URL: https://github.com/apache/iceberg-cpp/pull/746#discussion_r3486909101
##########
src/iceberg/util/temporal_util.cc:
##########
@@ -444,6 +444,11 @@ Result<int64_t>
TemporalUtils::ParseTimestampNsWithZone(std::string_view str) {
/*units_per_micro=*/internal::kNanosPerMicro);
}
+Result<bool> TemporalUtils::IsUtcOffset(std::string_view str) {
+ ICEBERG_ASSIGN_OR_RAISE(auto timestamp_with_offset,
ParseTimestampWithZoneSuffix(str));
Review Comment:
`Z`, `+00:00` and `-00:00` all denote a zero (UTC) offset, so accepting them
is consistent with UTC semantics even though the spec writes the canonical form
as `+00:00` (Java's `SingleValueParser` accepts the equivalents too).
Documented this explicitly on `TemporalUtils::IsUtcOffset` in 26b1f1b.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
