NoahKusaba commented on PR #2613: URL: https://github.com/apache/iceberg-rust/pull/2613#issuecomment-4827041709
@milenkovicm This is fine to look out now. The line count looks inflated due to tests + dependency shenanigans. The physical_codec.rs and logical_codec.rs are there to tie Ballista and the iceberg-datafusion integration together, and is probably fine. The bridge.rs stuff is the part I'd appreciate eyes on, which resolves concurrency blocking calls in async functions. I also only tested this on Rest + MinIO on my local PC, but it should work on rest/sql/glue/hms/s3tables via the OpenDalResolvingFactory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
