plusplusjiajia commented on PR #719: URL: https://github.com/apache/iceberg-cpp/pull/719#issuecomment-4823886654
@wgtmac Thanks a lot for the careful review and for getting this merged — and the point about self-review is well taken, I'll be more thorough going forward. The ArrowS3FileIO refactor reads really cleanly, too. While going back over the merged credential path, I ran into something I wanted to check with you. It looks like MakeTableFileIO chooses the FileIO impl from DetectBuiltinFileIO(warehouse), so when the warehouse isn't an s3:// path it resolves to arrow-fs-local, and binding the vended credentials then returns Configured FileIO does not support vended storage credentials. That seems to affect the catalogs that vend credentials, since their warehouse is usually a non-URI identifier (a bucket ARN for S3 Tables, a catalog/account id for Glue, a catalog name for Unity / Polaris) rather than an s3:// path — so I'm not quite sure how it's meant to work when the warehouse isn't s3://. I may be missing some context here — could you share how you'd suggest handling this? I'd be glad to put together a follow-up once we settle on an approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
