fallintoplace opened a new pull request, #1336:
URL: https://github.com/apache/iceberg-go/pull/1336
Summary
- reject malformed `rest.authorization-url` values instead of silently
ignoring them
- propagate auth URL parse failures from both initial catalog props and
fetched REST config
- add regression coverage for invalid local props and invalid server config
Why
`fromProps` previously swallowed `url.Parse` errors and left `authUri`
unset. When OAuth credentials were later used, the client fell back to
`baseURI.JoinPath("oauth/tokens")`, so a typo in `rest.authorization-url` could
quietly send credentials to a different endpoint than intended.
Testing
- `go test ./catalog/rest -run
'Test(LoadRegisteredCatalogRejectsInvalidAuthURL|NewCatalogRejectsInvalidAuthURLFromConfig)$'
-count=1`
- `go test ./catalog/rest -count=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
