dhruvarya-db commented on code in PR #2696:
URL: https://github.com/apache/iceberg-rust/pull/2696#discussion_r3483539638
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -86,17 +86,21 @@ impl DeleteFileIndex {
data_file: &DataFile,
seq_num: Option<i64>,
) -> Vec<FileScanTaskDeleteFile> {
- let notifier = {
+ // Create the `Notified` while holding the read lock.
`notify_waiters()` stores no
Review Comment:
Read the comment again, the suggestion makes sense. Will tighten the comment
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -86,17 +86,21 @@ impl DeleteFileIndex {
data_file: &DataFile,
seq_num: Option<i64>,
) -> Vec<FileScanTaskDeleteFile> {
- let notifier = {
+ // Create the `Notified` while holding the read lock.
`notify_waiters()` stores no
Review Comment:
Read the suggestion again, it makes sense. Will tighten the code comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
