zeroshade commented on code in PR #1314:
URL: https://github.com/apache/iceberg-go/pull/1314#discussion_r3482956848
##########
partitions_test.go:
##########
@@ -61,6 +73,32 @@ func TestPartitionSpec(t *testing.T) {
assert.Equal(t, 1002, spec3.LastAssignedFieldID())
}
+func TestPartitionSpecCompatibleWithUsesTransformEquals(t *testing.T) {
Review Comment:
nit: this nicely pins the non-comparable custom-transform path. It'd be
worth also asserting the built-in parameterized cases directly at the
`CompatibleWith` level - e.g. `bucket[16]` vs `bucket[32]` and `truncate[4]` vs
`truncate[8]` should be incompatible, while identical transforms stay
compatible. They work today via the built-in `Equals` impls, but a couple of
table-driven cases here would guard against regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
