u70b3 opened a new pull request, #2712: URL: https://github.com/apache/iceberg-rust/pull/2712
## Which issue does this PR close? - Closes #2711. ## What changes are included in this PR? Reject DataFusion `InsertOp::Overwrite` and `InsertOp::Replace` before constructing an Iceberg write plan. Previously, `IcebergTableProvider::insert_into` ignored the requested insert operation while the commit executor always used `fast_append`. Unsupported overwrite or replace requests could therefore be silently executed with append semantics. This PR keeps the existing append path unchanged and returns `DataFusionError::NotImplemented` for unsupported insert operations. ## Are these changes tested? Yes. Added unit tests verifying that: - `InsertOp::Overwrite` returns `DataFusionError::NotImplemented`. - `InsertOp::Replace` returns `DataFusionError::NotImplemented`. - Existing append-insert tests continue to pass. Local verification: - `cargo test -p iceberg-datafusion` - `cargo clippy -p iceberg-datafusion --all-targets -- -D warnings` - `cargo fmt --all -- --check` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
