tanmayrauth commented on code in PR #1315:
URL: https://github.com/apache/iceberg-go/pull/1315#discussion_r3471940595
##########
schema_test.go:
##########
@@ -442,6 +442,61 @@ func TestUnmarshalSchema(t *testing.T) {
assert.True(t, tableSchemaSimple.Equals(&schema))
}
+func TestUnmarshalSchemaRejectsDuplicateFieldIDs(t *testing.T) {
Review Comment:
Nice — the top-level and nested-struct cases are the important ones. Since
checkDuplicateFieldIDs also walks list element IDs and map key/value IDs
(schema.go:118-130), would you consider adding a list or map dup-ID case too?
Those branches are only exercised indirectly right now, and they're the easiest
to silently break later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
