Revanth14 commented on code in PR #1213:
URL: https://github.com/apache/iceberg-go/pull/1213#discussion_r3471230757
##########
catalog/rest/rest.go:
##########
@@ -109,9 +109,10 @@ func init() {
}
type errorResponse struct {
- Message string `json:"message"`
- Type string `json:"type"`
- Code int `json:"code"`
+ Message string `json:"message"`
+ Type string `json:"type"`
+ Code int `json:"code"`
+ Stack []string `json:"stack,omitempty"`
Review Comment:
Agreed. I kept `stack` on the internal wire error type, but stopped aliasing
that internal type into the planning API. `PlanningError` is now a dedicated
exported struct with the same ErrorModel fields, including `Stack`, so the
internal `wrapping`/`Error`/`Unwrap` behavior no longer leaks through the
public planning surface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
