CTTY commented on code in PR #2648:
URL: https://github.com/apache/iceberg-rust/pull/2648#discussion_r3470794196
##########
crates/integrations/datafusion/src/physical_plan/commit.rs:
##########
@@ -129,10 +128,6 @@ impl ExecutionPlan for IcebergCommitExec {
"IcebergCommitExec"
}
- fn as_any(&self) -> &dyn Any {
- self
Review Comment:
Great to see this gone!
##########
crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs:
##########
@@ -140,7 +140,8 @@ fn to_iceberg_predicate(expr: &Expr) -> TransformedResult {
}
}
Expr::Cast(c) => {
- if c.data_type == DataType::Date32 || c.data_type ==
DataType::Date64 {
+ if *c.field.data_type() == DataType::Date32 ||
*c.field.data_type() == DataType::Date64
Review Comment:
we may need to fix the data type comparison here as well:
https://github.com/apache/iceberg-rust/blob/main/crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs#L265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
