singhpk234 commented on code in PR #15903:
URL: https://github.com/apache/iceberg/pull/15903#discussion_r3468698846
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -282,6 +284,10 @@ public void initialize(String name, Map<String, String>
unresolved) {
RESTCatalogProperties.NAMESPACE_SEPARATOR,
RESTCatalogProperties.NAMESPACE_SEPARATOR_DEFAULT);
+ String scanPlanningModeConfig =
mergedProps.get(RESTCatalogProperties.SCAN_PLANNING_MODE);
+ this.scanPlanningModeClient =
Review Comment:
```suggestion
this.clientScanPlanningMode =
```
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -594,31 +600,34 @@ private RESTTable restTableForScanPlanning(
TableIdentifier finalIdentifier,
RESTClient restClient,
Map<String, String> tableConf) {
- // Get client-side and server-side scan planning modes
- String planningModeClientConfig =
properties().get(RESTCatalogProperties.SCAN_PLANNING_MODE);
String planningModeServerConfig =
tableConf.get(RESTCatalogProperties.SCAN_PLANNING_MODE);
-
- // Warn if client and server configs conflict; server config takes
precedence
- if (planningModeClientConfig != null
- && planningModeServerConfig != null
- &&
!planningModeClientConfig.equalsIgnoreCase(planningModeServerConfig)) {
+ ScanPlanningMode scanPlanningModeServer =
Review Comment:
```suggestion
ScanPlanningMode serverScanPlanningMode =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
