fallintoplace opened a new pull request, #1303: URL: https://github.com/apache/iceberg-go/pull/1303
Summary - reject equality delete files with no equality field IDs while loading scan deletes - add reader-level regression coverage for malformed delete metadata before any delete file is read Why Equality delete keys are built from the file's equality field IDs. If that list is empty, the reader can build an empty key, and every data row also encodes to that same empty key. A malformed equality delete file could therefore filter every row from an applicable scan. Writers already reject empty equality field IDs; this adds the same guard to the reader path for externally-written or malformed delete files. Testing - go test ./table -run '^TestReadAllEqualityDeleteFilesRejectsEmptyEqualityFieldIDs$' -count=1 - go test ./table -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/... - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
