fallintoplace opened a new pull request, #1301: URL: https://github.com/apache/iceberg-go/pull/1301
Summary - group newly added manifest entries by the added file's partition spec ID - write each added-file manifest with that matching partition spec - use the added file's own spec when collecting snapshot summary partition metrics - add a regression with added position deletes from old and current specs after spec evolution Why Position delete files can inherit their partition data and spec ID from the data file they reference. After partition spec evolution, a row-level delete can add a delete file whose spec ID is not the table's current spec ID. The added-file manifest path wrote every new data/delete file using the current spec. That could put an added delete file into a manifest whose `partition_spec_id` did not match the delete file's own spec. Deleted entries already group by spec ID before writing manifests; this applies the same rule to added files. Testing - go test ./table -run '^TestAddedDeleteManifestsUseDeleteFileSpecID$' -count=1 - go test ./table -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/... - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
