pvary commented on code in PR #16450:
URL: https://github.com/apache/iceberg/pull/16450#discussion_r3467184872
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableRecordGenerator.java:
##########
@@ -28,12 +34,61 @@
public abstract class DynamicTableRecordGenerator implements
DynamicRecordGenerator<RowData> {
Review Comment:
Is this a class where we need to keep compatibility with the already
released versions of the class? Do we need to deprecate the old constructor,
and add a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
