AhmedDlshad007 opened a new pull request, #1297: URL: https://github.com/apache/iceberg-go/pull/1297
## What Hardens `TestCreateAzureBucketManagedIdentityCredentialCalled` (`io/gocloud/azure_test.go`) so it actually distinguishes the managed-identity path from the `DefaultAzureCredential` fallback, as requested in #1277. The existing assertion only checks that the error contains `"ManagedIdentityCredential"`. But `DefaultAzureCredential` includes `ManagedIdentityCredential` in its chain and aggregates each source's error, so a regression that fell back to `DefaultAzureCredential` would still satisfy that assertion and pass unnoticed. This adds `assert.NotContains(err.Error(), "DefaultAzureCredential")`, which passes on the current managed-identity-only path and would fail if the code regressed to `DefaultAzureCredential`. No production code changes; test-only. Closes #1277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
