kamcheungting-db commented on code in PR #724:
URL: https://github.com/apache/iceberg-cpp/pull/724#discussion_r3466473315
##########
src/iceberg/logging/logger.h:
##########
@@ -127,8 +127,8 @@ class ICEBERG_EXPORT LogMessage::Builder {
/// \brief Well-known Logger::Initialize() property keys.
///
/// `level` is honored by the base Logger::Initialize (parsed via
-/// LogLevelFromString). `pattern` is honored by the formatting sinks
-/// (CerrLogger, SpdLogger).
+/// LogLevelFromString) on every backend. `pattern` is honored only by the
+/// spdlog backend; CerrLogger uses a fixed layout and ignores it.
Review Comment:
Updated
##########
src/iceberg/CMakeLists.txt:
##########
@@ -131,6 +132,7 @@ set(ICEBERG_SOURCES
util/struct_like_set.cc
util/task_group.cc
util/temporal_util.cc
+ util/thread_util_internal.cc
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
