rdblue commented on code in PR #16769:
URL: https://github.com/apache/iceberg/pull/16769#discussion_r3463693718
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -75,40 +71,34 @@ class TestTrackedFileAdapters {
// TrackedFile optional field ordinals, looked up from the schema.
private static final Types.StructType TRACKED_FILE_SCHEMA =
TrackedFile.schemaWithContentStats(Types.StructType.of(),
Types.StructType.of());
+ private static final int CONTENT_TYPE_ORDINAL =
ordinalOf(TRACKED_FILE_SCHEMA, "content_type");
Review Comment:
Why does this introduce another ordinal? I think these are bad practice
(these tests should not be using set/get) so I'm surprised to see that this
eliminates some, but introduces others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
