Baunsgaard commented on code in PR #16937:
URL: https://github.com/apache/iceberg/pull/16937#discussion_r3463557669
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -164,6 +167,12 @@ protected static List<Integer> parameters() {
private final ScanTaskSetManager manager = ScanTaskSetManager.get();
private String tableLocation = null;
+ // Mirror of the rows written natively via appendRecords, in the {c1, c2,
c3} shape that
+ // currentData() returns. Lets tests that only compact (which preserves row
content) assert
+ // against the known input via expectedData() instead of paying a second
Spark read+sort+collect
+ // just to re-materialize what they wrote. Reset per test in
setupTableLocation().
+ private final List<Object[]> writtenRecords = Lists.newArrayList();
Review Comment:
Ya, I have not gotten to the cleanup of the comments yet. I have now reduced
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
