dhruvarya-db commented on PR #2667: URL: https://github.com/apache/iceberg-rust/pull/2667#issuecomment-4783914491
Thanks for the careful review @laskoviymishka, and @viirya for verifying the design! Pushed 184ea96 addressing all four notes: - **Update ordering**: stats removals now land after the `RemoveSnapshots` push (refs -> snapshots -> stats). - **Ref-aging coverage**: added `test_ref_aging_expiry_drops_statistics`, which expires a snapshot purely because its sole ref aged out. - **Multi-snapshot coverage**: added `test_multiple_expired_snapshots_drop_their_statistics` asserting `removed_statistics == [1, 2]`. - **Helper dedup**: `table_with_stats` now builds on `table_with` instead of duplicating the wiring. - Also took the `for &snapshot_id` cleanup. All 34 `transaction::expire_snapshots` tests pass; clippy + rustfmt clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
