laskoviymishka opened a new issue, #1272: URL: https://github.com/apache/iceberg-go/issues/1272
Follow-up to #1104. `glue.PurgeTable` and `hive.PurgeTable` both call `DropTable` then `tbl.PurgeFiles`, swallowing a `PurgeFiles` error with a warning log — and neither path has a test. `TestGlueDropTable` / `TestHiveDropTable` exercise `DropTable` alone and never plumb a `FileIO`, so `PurgeFiles` is never invoked under the mocks. `catalog/sql`'s `TestPurgeTable` / `TestPurgeTableGCDisabled` and `catalog/rest`'s `TestPurgeTable204` already show the shape. Add `TestGluePurgeTable` and `TestHivePurgeTable` that load a table backed by an in-memory or local `FileIO` with real data files, call `PurgeTable`, and assert both that the drop fires and that the files are physically gone. Include a case where `PurgeFiles` fails, to lock in the best-effort swallow-and-log behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
