wgtmac commented on code in PR #751:
URL: https://github.com/apache/iceberg-cpp/pull/751#discussion_r3460814606
##########
src/iceberg/table.cc:
##########
@@ -217,6 +218,12 @@ Result<std::shared_ptr<FastAppend>> Table::NewFastAppend()
{
return FastAppend::Make(name().name, std::move(ctx));
}
+Result<std::shared_ptr<RewriteFiles>> Table::NewRewriteFiles() {
Review Comment:
StaticTable inherits this method too. That lets a read-only table create a
rewrite update, then fail later when Commit reaches the null catalog. Java
rejects newRewrite() in BaseReadOnlyTable; StaticTable should override this
like the other mutating APIs and return NotSupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
