singhpk234 commented on code in PR #16935:
URL: https://github.com/apache/iceberg/pull/16935#discussion_r3455876764
##########
core/src/main/java/org/apache/iceberg/ManifestLists.java:
##########
@@ -32,16 +32,12 @@
class ManifestLists {
private ManifestLists() {}
- static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
- InputFile input = io.newInputFile(manifestList);
- if (ManifestFiles.cachingEnabled(io)) {
- return ManifestFiles.contentCache(io).tryCache(input);
+ static List<ManifestFile> read(InputFile manifestList) {
+ if (!manifestList.exists()) {
+ throw new NotFoundException(
+ "Failed to read manifest list: file %s does not exist",
manifestList.location());
}
Review Comment:
This will introduce an object store call per read ?
its better to fix the GCSInputFile if the blob doesn't exists
https://github.com/apache/iceberg/blob/7c13104c8c20323c895aeb33fe5ca1f3b127889f/gcp/src/main/java/org/apache/iceberg/gcp/gcs/BaseGCSFile.java#L85
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
