fallintoplace opened a new pull request, #1257: URL: https://github.com/apache/iceberg-go/pull/1257
Summary - remove the incomplete Parquet file when ParquetFileWriter.Abort is called - return both close and remove failures from Abort with errors.Join - cover direct abort cleanup and the rolling writer deferred-abort path Why #1241 switched failed batch writes to Abort instead of Close, but Abort still only closed the handle. On object stores that could leave a footer-less object behind even though the snapshot never commits it. Testing - go test ./table/internal -run 'TestParquetFileWriterAbort|TestWriteDataFileBatchesAbortsOnWriteError' -count=1\n- go test ./table -run 'TestRollingDataWriter/TestAbortWithZeroRowsWritten|TestRollingDataWriter/TestStreamErrorPathUsesAbort' -count=1\n- go test ./table/internal -count=1\n- go test ./table -count=1\n- go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/...\n- git diff --check\n\nCloses #1247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
