sungwy commented on code in PR #3491:
URL: https://github.com/apache/iceberg-python/pull/3491#discussion_r3455633674
##########
pyiceberg/table/puffin.py:
##########
@@ -105,12 +65,15 @@ def __init__(self, puffin: bytes) -> None:
footer_payload_size_int = int.from_bytes(puffin[-12:-8],
byteorder="little")
self.footer =
Footer.model_validate_json(puffin[-(footer_payload_size_int + 12) : -12])
- puffin = puffin[8:]
+ self._payload = puffin[8:]
- self._deletion_vectors = {
- blob.properties[PROPERTY_REFERENCED_DATA_FILE]:
_deserialize_bitmap(puffin[blob.offset : blob.offset + blob.length])
- for blob in self.footer.blobs
- }
+ def get_blob_payload(self, blob: PuffinBlobMetadata) -> bytes:
+ return self._payload[blob.offset : blob.offset + blob.length]
+ @deprecated(
+ deprecated_in="0.12.0", removed_in="0.13.0", help_message="Use
DeletionVector.from_bytes(...).to_vector() instead"
Review Comment:
Thanks @ebyhr - I have just one more nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
