badalprasadsingh opened a new issue, #1251:
URL: https://github.com/apache/iceberg-go/issues/1251

   ### Feature Request / Improvement
   
   ## Background
   
   This is a follow-up on the 
[discussion](https://github.com/apache/iceberg-go/pull/1227#issuecomment-4746198642)
 at PR #1227.
   
   `iceberg.Transform.ToHumanStr(any) string` is value-only. Because Iceberg's 
`TimestampType` and `TimestampTzType` both surface as `iceberg.Timestamp` in 
Go, the source type cannot be recovered at the call site, so 
`IdentityTransform` cannot render `TimestampTz` partition values with the 
`+00:00` suffix.
   
   A previous PR ( fixing #1226 ) worked around this by introducing an 
unexported `typedHumanStringer` extension interface, type-asserting it inside 
`PartitionToPath`, and falling back to `ToHumanStr` otherwise. That works but 
leaves a private _shim_ in place and keeps the public API **misleading**.
   
   ## Proposal
   
   Mirror `Iceberg-Java`'s deprecation path (`Transform.toHumanString(T)` → 
`Transform.toHumanString(Type, T)`).
   
   ## Compatibility
   
   This is a **breaking change** for external implementers of the public 
`Transform` interface — they will need to add `ToHumanStrType`. All in-tree 
implementations are updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to