brgr-s commented on PR #2620: URL: https://github.com/apache/iceberg-rust/pull/2620#issuecomment-4769046634
@CTTY I added a second cherry-pick-able (?) commit, that allows `filter_manifests` to be called with `fail_missing_delete_paths: true`. Java does something similar, where a rewrite required that all files that the rewrite wants to delete need to still exist. I haven't managed to write a test, and the "design" could maybe use some re-thinking. I renamed `deleted_files` to `delete_files`; `delete_files` conflicts with the notion of "a (equality/position) delete file", but Java used the convenction `deleteFiles` for the files that the operation wants to delete and `deletedFiles` for the files it actually dropped (different internal logic, they keep track of the latter, which we don't). Here is the commit: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
