leeyam24 commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3451755566
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -321,6 +321,24 @@ private Result rebuildMetadata() {
.collect(Collectors.toCollection(DeleteFileSet::create));
rewritePositionDeletes(deleteFiles);
+ // rebuild manifest-list files last, stamping manifest_length with the
rewritten manifest sizes
+ Set<RewriteResult<ManifestFile>> manifestListResults =
Sets.newConcurrentHashSet();
+ Tasks.foreach(validSnapshots)
Review Comment:
Note on performance: this loop currently defaults to single-threaded
execution because PySpark/SQL cannot configure an Executor Service, directly
causing slower runtimes for rewrite_table_path. I've raised a [feature
request](https://github.com/apache/iceberg/issues/16752) to address this, and I
believe it's an important bottleneck we should advocate to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
