wombatu-kun commented on code in PR #16544: URL: https://github.com/apache/iceberg/pull/16544#discussion_r3451186997
########## site/mkdocs.yml: ########## @@ -112,6 +112,7 @@ markdown_extensions: extra: icebergVersion: '1.11.0' + snapshotVersion: '1.12.0-SNAPSHOT' Review Comment: `snapshotVersion` can't reuse `icebergVersion`; they're different values. `getProjectVersion()` in `build.gradle` derives the snapshot from the latest release tag by bumping the minor and zeroing the patch, so the published snapshot is `1.12.0-SNAPSHOT` while `icebergVersion` is `1.11.0`. Reusing `icebergVersion` would document `1.11.0`, a released artifact that isn't in the snapshot repo, so the examples wouldn't resolve. The note added to `how-to-release.md` keeps `snapshotVersion` from going stale at release time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
