Revanth14 commented on code in PR #1239:
URL: https://github.com/apache/iceberg-go/pull/1239#discussion_r3449768639
##########
table/arrow_utils.go:
##########
@@ -1884,22 +1921,26 @@ func geoArrowCRSToIcebergCRS(meta geoarrow.Metadata)
(string, error) {
return "", fmt.Errorf("invalid geoarrow CRS metadata:
%w", err)
}
- if strings.EqualFold(crs, "OGC:CRS84") ||
strings.EqualFold(crs, "EPSG:4326") {
- return "OGC:CRS84", nil
- }
-
switch meta.CRSType {
case geoarrow.CRSTypeSRID:
return "srid:" + crs, nil
+ case geoarrow.CRSTypePROJJSON:
Review Comment:
I kept the rejection here intentionally.
`crs_type:"projjson"` says the CRS payload should be PROJJSON, so a string
CRS with that annotation is invalid for this path. I agree it is a
read-tolerance change from the old best-effort canonicalization, but this is
one of the unsupported encodings the PR is meant to reject.
I kept that behavior covered with the `projjson` string CRS test, and I’ll
call it out in the PR description so the compatibility change is explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
