kevinjqliu commented on code in PR #3547:
URL: https://github.com/apache/iceberg-python/pull/3547#discussion_r3449383681
##########
tests/expressions/test_evaluator.py:
##########
@@ -1523,7 +1609,7 @@ def test_strict_integer_not_in(strict_data_file_schema:
Schema, strict_data_file
assert should_read, "Should match: notIn on all nulls column"
should_read = _StrictMetricsEvaluator(strict_data_file_schema,
NotIn("some_nulls", {"abc", "def"})).eval(strict_data_file_1)
- assert should_read, "Should match: notIn on some nulls column, 'bbb' >
'abc' and 'bbb' < 'def'"
+ assert not should_read, "Should not match: mixed-null notIn cannot be
proven when bounds are missing"
Review Comment:
`some_nulls` has `value_count = 50` and `null_count = 10`
* Its field id is `5` in
[strict_data_file_schema](https://github.com/apache/iceberg-python/blob/c66d8b5f6c122d3bdedbad1a39d4ef213e19d50d/tests/expressions/test_evaluator.py#L1021-L1060)
So 40 values are non-null, but without lower/upper bounds the strict
evaluator cannot rule out "abc" or "def" among them.
Before the fix, “column can contain nulls” incorrectly caused
ROWS_MUST_MATCH; now only “column contains nulls only” can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
