thswlsqls commented on code in PR #16886:
URL: https://github.com/apache/iceberg/pull/16886#discussion_r3449150753


##########
dell/src/test/java/org/apache/iceberg/dell/ecs/TestEcsURI.java:
##########
@@ -59,4 +59,11 @@ public void testInvalidLocation() {
         .isInstanceOf(ValidationException.class)
         .hasMessage("Invalid ecs location: http://bucket/a";);
   }
+
+  @Test
+  public void testNullLocation() {
+    assertThatThrownBy(() -> new EcsURI((String) null))
+        .isInstanceOf(NullPointerException.class)
+        .hasMessageContaining("can not be null");

Review Comment:
   Done. 
   
   Switched to hasMessage("Location can not be null"), which also matches the 
style of testInvalidLocation in the same file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to